Skip to content

Feature gate non-builtin attributes in inner attribute position #54093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2018
Merged

Feature gate non-builtin attributes in inner attribute position #54093

merged 1 commit into from
Sep 10, 2018

Conversation

petrochenkov
Copy link
Contributor

Closes item 3 from #50911 (comment)

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2018
@petrochenkov
Copy link
Contributor Author

r? @alexcrichton

@petrochenkov
Copy link
Contributor Author

@bors p=1
This needs to be merged before beta, which is in a few days (or backported later).

@petrochenkov petrochenkov added the P-high High priority label Sep 10, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 10, 2018

📌 Commit 615eaba has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2018
@petrochenkov petrochenkov removed the P-high High priority label Sep 10, 2018
@bors
Copy link
Collaborator

bors commented Sep 10, 2018

⌛ Testing commit 615eaba with merge 551244f...

bors added a commit that referenced this pull request Sep 10, 2018
@bors
Auto merge of #54093 - petrochenkov:noinner, r=alexcrichton
551244f 
Feature gate non-builtin attributes in inner attribute position

Closes item 3 from #50911 (comment)
@bors
Copy link
Collaborator

bors commented Sep 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 551244f to master...

@bors bors merged commit 615eaba into rust-lang:master Sep 10, 2018
This was referenced Sep 10, 2018
Merged
Merged
@alexcrichton alexcrichton mentioned this pull request Oct 1, 2018
Open
@petrochenkov petrochenkov deleted the noinner branch June 5, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrochenkov @rust-highfive @alexcrichton @bors @michaelwoerister